netdev - Re: [PATCH v5 0/8] Introduce fwctl subystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317123059.GA9311@nvidia.com>
Date: Mon, 17 Mar 2025 09:30:59 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: David Ahern <dsahern@...nel.org>
Cc: Leon Romanovsky <leon@...nel.org>, Saeed Mahameed <saeed@...nel.org>,
	Jiri Pirko <jiri@...nulli.us>, Jakub Kicinski <kuba@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Gospodarek <andrew.gospodarek@...adcom.com>,
	Aron Silverton <aron.silverton@...cle.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Dave Jiang <dave.jiang@...el.com>,
	Christoph Hellwig <hch@...radead.org>,
	Itay Avraham <itayavr@...dia.com>, Jiri Pirko <jiri@...dia.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Leonid Bloch <lbloch@...dia.com>, linux-cxl@...r.kernel.org,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>,
	"Nelson, Shannon" <shannon.nelson@....com>
Subject: Re: [PATCH v5 0/8] Introduce fwctl subystem

On Wed, Mar 12, 2025 at 10:31:51AM +0100, David Ahern wrote:

> I hope there will be an open mind on get / dump style introspection apis
> here. Devices can work support and work within limited subsystem APIs
> and also allow the dumping of full essential and relevant contexts for a
> device.

We have three places to put dumpables like you are talking about,
fwctl, netdev and rdma

rdma already has a robust dumper for these kinds of objects.

netdev drivers have a few options, and people use debugfs there.

fwctl is supposed to let you dump the FW side view of the sytem.

Do you *really* need another one? It sounds excessive to me.

> More specifically, I do not see netdev APIs ever recognizing RDMA
> concepts like domains and memory regions. 

Why not? If netdev is going to provide the same detailed view of the
HW state we expect from fwctl it will need to provide ways to dump
the actualy underlying HW objects, whatever they may be.

It is not like building a netdev driver on top of RDMA is anything
new, mlx5 does it as well.

> For us, everything is relative to a domain and a region - e.g.,
> whether a queue is created for a netdev device or an IB QP both use
> the same common internal APIs.  I would prefer not to use fwctl for
> something so basic.

It is probably the right answer though.

Jason