netdev - RE: [Intel-wired-lan] [iwl-net v3 1/5] virtchnl: make proto and filter action count unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865019255CD0443700C892A8FDF2@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Mon, 17 Mar 2025 13:29:30 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@...ux.intel.com>, "Paul
 Menzel" <pmenzel@...gen.mpg.de>, "Glaza, Jan" <jan.glaza@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, Simon Horman <horms@...nel.org>, "Lobakin,
 Aleksander" <aleksander.lobakin@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-net v3 1/5] virtchnl: make proto and
 filter action count unsigned

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Szapar-Mudlaw, Martyna
> Sent: Tuesday, March 4, 2025 2:12 PM
> To: Paul Menzel <pmenzel@...gen.mpg.de>; Glaza, Jan <jan.glaza@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Jagielski, Jedrzej
> <jedrzej.jagielski@...el.com>; Simon Horman <horms@...nel.org>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>
> Subject: Re: [Intel-wired-lan] [iwl-net v3 1/5] virtchnl: make proto and filter
> action count unsigned
> 
> 
> 
> On 3/4/2025 12:51 PM, Paul Menzel wrote:
> > Dear Martyna,
> >
> >
> > Thank you for your quick reply.
> >
> > Am 04.03.25 um 12:45 schrieb Szapar-Mudlaw, Martyna:
> >
> >> On 3/4/2025 12:15 PM, Paul Menzel wrote:
> >
> >>> Am 04.03.25 um 12:08 schrieb Martyna Szapar-Mudlaw:
> >>>> From: Jan Glaza <jan.glaza@...el.com>
> >>>>
> >>>> The count field in virtchnl_proto_hdrs and
> >>>> virtchnl_filter_action_set should never be negative while still
> >>>> being valid. Changing it from int to u32 ensures proper handling of
> >>>> values in virtchnl messages in driverrs and prevents unintended behavior.
> >>>> In its current signed form, a negative count does not trigger an
> >>>> error in ice driver but instead results in it being treated as 0.
> >>>> This can lead to unexpected outcomes when processing messages.
> >>>> By using u32, any invalid values will correctly trigger -EINVAL,
> >>>> making error detection more robust.
> >>>>
> >>>> Fixes: 1f7ea1cd6a374 ("ice: Enable FDIR Configure for AVF")
> >>>> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> >>>> Reviewed-by: Simon Horman <horms@...nel.org>
> >>>> Signed-off-by: Jan Glaza <jan.glaza@...el.com>
> >>>> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-
> >>>> mudlaw@...ux.intel.com>
> >>>> ---
> >>>>   include/linux/avf/virtchnl.h | 4 ++--
> >>>>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/
> >>>> virtchnl.h index 4811b9a14604..cf0afa60e4a7 100644
> >>>> --- a/include/linux/avf/virtchnl.h
> >>>> +++ b/include/linux/avf/virtchnl.h
> >>>> @@ -1343,7 +1343,7 @@ struct virtchnl_proto_hdrs {


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>