netdev - Re: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317063620.30d24269@hermes.local>
Date: Mon, 17 Mar 2025 06:36:20 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: chia-yu.chang@...ia-bell-labs.com
Cc: netdev@...r.kernel.org, dave.taht@...il.com, pabeni@...hat.com,
 jhs@...atatu.com, kuba@...nel.org, xiyou.wangcong@...il.com,
 jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, andrew+netdev@...n.ch, donald.hunter@...il.com,
 ast@...erby.net, liuhangbin@...il.com, shuah@...nel.org,
 linux-kselftest@...r.kernel.org, ij@...nel.org, ncardwell@...gle.com,
 koen.de_schepper@...ia-bell-labs.com, g.white@...lelabs.com,
 ingemar.s.johansson@...csson.com, mirja.kuehlewind@...csson.com,
 cheshire@...le.com, rs.ietf@....at, Jason_Livingood@...cast.com,
 vidhi_goel@...le.com, Olga Albisser <olga@...isser.org>, Oliver Tilmans
 <olivier.tilmans@...ia.com>, Bob Briscoe <research@...briscoe.net>, Henrik
 Steen <henrist@...rist.net>
Subject: Re: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module

On Sun, 16 Mar 2025 16:39:17 +0100
chia-yu.chang@...ia-bell-labs.com wrote:

> +static int dualpi2_print_xstats(struct qdisc_util *qu, FILE *f,
> +			    struct rtattr *xstats)
> +{
> +	struct tc_dualpi2_xstats *st;
> +
> +	if (xstats == NULL)
> +		return 0;
> +
> +	if (RTA_PAYLOAD(xstats) < sizeof(*st))
> +		return -1;
> +
> +	st = RTA_DATA(xstats);
> +	fprintf(f, "prob %f delay_c %uus delay_l %uus\n",
> +		(double)st->prob / (double)MAX_PROB, st->delay_c, st->delay_l);
> +	fprintf(f, "pkts_in_c %u pkts_in_l %u maxq %u\n",
> +		st->packets_in_c, st->packets_in_l, st->maxq);
> +	fprintf(f, "ecn_mark %u step_marks %u\n", st->ecn_mark, st->step_marks);
> +	fprintf(f, "credit %d (%c)\n", st->credit, st->credit > 0 ? 'C' : 'L');
> +	fprintf(f, "memory used %u (max %u) of memory limit %u\n",
> +		st->memory_used, st->max_memory_used, st->memory_limit);
> +	return 0;
> +

You should support JSON for the stats as well.