netdev - Re: [PATCH net-next] tcp: move icsk_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQynTumXjmCWyHY25+WF=B+-qwMH_TS_MSJOrD=txE5OdzQ@mail.gmail.com>
Date: Mon, 17 Mar 2025 10:55:31 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Boris Pismenny <borisp@...dia.com>, John Fastabend <john.fastabend@...il.com>, 
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: move icsk_clean_acked to a better location

On Mon, Mar 17, 2025 at 4:53 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> As a followup of my presentation in Zagreb for netdev 0x19:
>
> icsk_clean_acked is only used by TCP when/if CONFIG_TLS_DEVICE
> is enabled from tcp_ack().
>
> Rename it to tcp_clean_acked, move it to tcp_sock structure
> in the tcp_sock_read_rx for better cache locality in TCP
> fast path.
>
> Define this field only when CONFIG_TLS_DEVICE is enabled
> saving 8 bytes on configs not using it.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Very nice! Thanks, Eric!

For clarity for readers, at some point I wonder if we might want to
rename clean_acked_data_enable() and clean_acked_data_disable() to
have a tcp_ prefix in their names, since those functions are only
used/declared/defined in a TCP context.

Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

neal