netdev - Re: [PATCH net-next 10/18] openvswitch: Merge three per-CPU structures into one.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64d435b2-ef49-4be3-aa73-a065d7b9fbbf@redhat.com>
Date: Mon, 17 Mar 2025 18:38:47 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 netdev@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
 Aaron Conole <aconole@...hat.com>, Eelco Chaudron <echaudro@...hat.com>,
 Ilya Maximets <i.maximets@....org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Pravin B Shelar <pshelar@....org>, dev@...nvswitch.org
Subject: Re: [PATCH net-next 10/18] openvswitch: Merge three per-CPU
 structures into one.

On 3/17/25 6:34 PM, Paolo Abeni wrote:
> On 3/9/25 3:46 PM, Sebastian Andrzej Siewior wrote:
>> exec_actions_level is a per-CPU integer allocated at compile time.
>> action_fifos and flow_keys are per-CPU pointer and have their data
>> allocated at module init time.
>> There is no gain in splitting it, once the module is allocated, the
>> structures are allocated.
>>
>> Merge the three per-CPU variables into ovs_action, adapt callers.
>>
>> Cc: Pravin B Shelar <pshelar@....org>
>> Cc: dev@...nvswitch.org
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
>> ---
>>  net/openvswitch/actions.c  | 49 +++++++++++++-------------------------
>>  net/openvswitch/datapath.c |  9 +------
>>  net/openvswitch/datapath.h |  3 ---
>>  3 files changed, 17 insertions(+), 44 deletions(-)
>>
>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
>> index 704c858cf2093..322ca7b30c3bc 100644
>> --- a/net/openvswitch/actions.c
>> +++ b/net/openvswitch/actions.c
>> @@ -78,17 +78,22 @@ struct action_flow_keys {
>>  	struct sw_flow_key key[OVS_DEFERRED_ACTION_THRESHOLD];
>>  };
>>  
>> -static struct action_fifo __percpu *action_fifos;
>> -static struct action_flow_keys __percpu *flow_keys;
>> -static DEFINE_PER_CPU(int, exec_actions_level);
>> +struct ovs_action {
>> +	struct action_fifo action_fifos;
>> +	struct action_flow_keys flow_keys;
>> +	int exec_level;
>> +};
> 
> I have the feeling this is not a very good name, as 'OVS action' has a
> quite specific meaning, not really matched here.
> 
> Also more OVS people, as Pravin is not really active anymore.

FTR, I'm processing the PW backlog in sequence (and with latency...),
and I see only now this point has been discussed in the next patch.
Sorry for the noise.

/P