netdev - Re: [PATCH net-next 1/2] tcp/dccp: remove icsk->icsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317202232.23864-1-kuniyu@amazon.com>
Date: Mon, 17 Mar 2025 13:21:56 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <borisp@...dia.com>, <davem@...emloft.net>, <eric.dumazet@...il.com>,
	<horms@...nel.org>, <john.fastabend@...il.com>, <kuba@...nel.org>,
	<kuniyu@...zon.com>, <ncardwell@...gle.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH net-next 1/2] tcp/dccp: remove icsk->icsk_timeout

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 17 Mar 2025 15:14:00 +0000
> icsk->icsk_timeout can be replaced by icsk->icsk_retransmit_timer.expires
> 
> This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

We may want to add a paired WRITE_ONCE() in __mod_timer() later.

Btw, DCCP removal series is almost ready and I will post it
in the next cycle as the patch queue is long now.