netdev - Re: [PATCH bpf-next v5 12/13] selftests/bpf: Add a bpf fq qdisc to selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMB2axO9siaKQ6yLyzeFR8v1bxJLUo3Aiu-Cf2r9zxhY5LdyBA@mail.gmail.com>
Date: Mon, 17 Mar 2025 01:25:55 +0000
From: Amery Hung <ameryhung@...il.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...nel.org>, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>, 
	Jamal Hadi Salim <jhs@...atatu.com>, Kui-Feng Lee <sinquersw@...il.com>, 
	Toke Høiland-Jørgensen <toke@...hat.com>, 
	Jiri Pirko <jiri@...nulli.us>, Stanislav Fomichev <stfomichev@...il.com>, 
	ekarani.silvestre@....ufcg.edu.br, yangpeihao@...u.edu.cn, 
	Peilin Ye <yepeilin.cs@...il.com>, Kernel Team <kernel-team@...a.com>
Subject: Re: [PATCH bpf-next v5 12/13] selftests/bpf: Add a bpf fq qdisc to selftest

On Fri, Mar 14, 2025 at 8:35 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Thu, Mar 13, 2025 at 12:03 PM Amery Hung <ameryhung@...il.com> wrote:
> >
> > From: Amery Hung <amery.hung@...edance.com>
> >
> > This test implements a more sophisticated qdisc using bpf. The bpf fair-
> > queueing (fq) qdisc gives each flow an equal chance to transmit data. It
> > also respects the timestamp of skb for rate limiting.
> >
> > Signed-off-by: Amery Hung <amery.hung@...edance.com>
> > ---
> >  .../selftests/bpf/prog_tests/bpf_qdisc.c      |  24 +
> >  .../selftests/bpf/progs/bpf_qdisc_fq.c        | 718 ++++++++++++++++++
>
> On the look of it, it's a pretty functional qdisc.
> Since bpftool supports loading st_ops,
> please list commands bpftool and tc the one can enter
> to use this qdisc without running selftests.
>

Thanks for the suggestion. That should be very helpful. I will add the commands.

> Probably at the comment section at the top of bpf_qdisc_fq.c
>
> It also needs SPDX and copyright.

I will add SPDX and copyright as well.

Thanks,
Amery

>
> pw-bot: cr