netdev - Re: [PATCH net-next 0/3] Fix late DMA unmap crash for page pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80bb0e6c-99eb-4c8f-ac00-0c048ec7bbb1@huawei.com>
Date: Mon, 17 Mar 2025 10:02:47 +0800
From: Yonglong Liu <liuyonglong@...wei.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>, "David S.
 Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jesper
 Dangaard Brouer <hawk@...nel.org>, Saeed Mahameed <saeedm@...dia.com>, Leon
 Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
	<pabeni@...hat.com>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, Simon
 Horman <horms@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Mina
 Almasry <almasrymina@...gle.com>, Yunsheng Lin <linyunsheng@...wei.com>,
	Pavel Begunkov <asml.silence@...il.com>, Matthew Wilcox <willy@...radead.org>
CC: <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <linux-mm@...ck.org>, Qiuling Ren
	<qren@...hat.com>, Yuying Ma <yuma@...hat.com>
Subject: Re: [PATCH net-next 0/3] Fix late DMA unmap crash for page pool

I know this solution is still under discussion, but anyway, I tested the
scenarios I reported in:

[0]https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/

It seems the problem has been solved. Thanks!


Tested-by: Yonglong Liu<liuyonglong@...wei.com>

On 2025/3/14 18:10, Toke Høiland-Jørgensen wrote:
> This series fixes the late dma_unmap crash for page pool first reported
> by Yonglong Liu in [0]. It is an alternative approach to the one
> submitted by Yunsheng Lin, most recently in [1]. The first two commits
> are small refactors of the page pool code, in preparation of the main
> change in patch 3. See the commit message of patch 3 for the details.
>
> -Toke
>
> [0] https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/
> [1] https://lore.kernel.org/r/20250307092356.638242-1-linyunsheng@huawei.com
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
> Toke Høiland-Jørgensen (3):
>        page_pool: Move pp_magic check into helper functions
>        page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap
>        page_pool: Track DMA-mapped pages and unmap them when destroying the pool
>
>   drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c |  4 +-
>   include/net/page_pool/helpers.h                  |  6 +-
>   include/net/page_pool/types.h                    | 54 +++++++++++++++-
>   mm/page_alloc.c                                  |  9 +--
>   net/core/devmem.c                                |  3 +-
>   net/core/netmem_priv.h                           | 33 +++++++++-
>   net/core/page_pool.c                             | 81 ++++++++++++++++++++----
>   net/core/skbuff.c                                | 16 +----
>   net/core/xdp.c                                   |  4 +-
>   9 files changed, 164 insertions(+), 46 deletions(-)
> ---
> base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe
> change-id: 20250310-page-pool-track-dma-0332343a460e
>
>