netdev - Re: [PATCH net-next 3/7] bnxt_en: Add devlink support for ENABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17915ef1-d118-4e93-a46e-b63968aaa49b@redhat.com>
Date: Tue, 18 Mar 2025 10:22:43 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, kuba@...nel.org,
 andrew+netdev@...n.ch, pavan.chebbi@...adcom.com,
 andrew.gospodarek@...adcom.com, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 3/7] bnxt_en: Add devlink support for ENABLE_ROCE
 nvm parameter

On 3/10/25 7:31 PM, Michael Chan wrote:
> @@ -1128,6 +1130,32 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
>  	return bnxt_hwrm_nvm_req(bp, id, req, &ctx->val);
>  }
>  
> +static int bnxt_dl_roce_validate(struct devlink *dl, u32 id,
> +				 union devlink_param_value val,
> +				 struct netlink_ext_ack *extack)
> +{
> +	const struct bnxt_dl_nvm_param nvm_roce_cap = {0, NVM_OFF_RDMA_CAPABLE,
> +		BNXT_NVM_SHARED_CFG, 1, 1};
> +	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
> +	struct hwrm_nvm_get_variable_input *req;
> +	union devlink_param_value roce_cap;
> +	int rc;
> +
> +	rc = hwrm_req_init(bp, req, HWRM_NVM_GET_VARIABLE);
> +	if (rc)
> +		return rc;

Not blocking this series, but I'm wondering: any special reason to not
fill the extack here? Could possibly be a small follow-up.

Thanks,

Paolo