netdev - RE: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR07MB7984DC2DA693FD00EABC0392A3DE2@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Tue, 18 Mar 2025 12:51:47 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Stephen Hemminger <stephen@...workplumber.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dave.taht@...il.com"
	<dave.taht@...il.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "horms@...nel.org"
	<horms@...nel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"donald.hunter@...il.com" <donald.hunter@...il.com>, "ast@...erby.net"
	<ast@...erby.net>, "liuhangbin@...il.com" <liuhangbin@...il.com>,
	"shuah@...nel.org" <shuah@...nel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "ij@...nel.org" <ij@...nel.org>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, g.white <g.white@...lelabs.com>,
	"ingemar.s.johansson@...csson.com" <ingemar.s.johansson@...csson.com>,
	"mirja.kuehlewind@...csson.com" <mirja.kuehlewind@...csson.com>,
	"cheshire@...le.com" <cheshire@...le.com>, "rs.ietf@....at" <rs.ietf@....at>,
	"Jason_Livingood@...cast.com" <Jason_Livingood@...cast.com>, vidhi_goel
	<vidhi_goel@...le.com>, Olga Albisser <olga@...isser.org>, "Olivier Tilmans
 (Nokia)" <olivier.tilmans@...ia.com>, Bob Briscoe <research@...briscoe.net>,
	Henrik Steen <henrist@...rist.net>
Subject: RE: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module

> From: Stephen Hemminger <stephen@...workplumber.org> 
> Sent: Monday, March 17, 2025 2:41 PM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
> Cc: netdev@...r.kernel.org; dave.taht@...il.com; pabeni@...hat.com; jhs@...atatu.com; kuba@...nel.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; edumazet@...gle.com; horms@...nel.org; andrew+netdev@...n.ch; donald.hunter@...il.com; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white <g.white@...lelabs.com>; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel <vidhi_goel@...le.com>; Olga Albisser <olga@...isser.org>; Olivier Tilmans (Nokia) <olivier.tilmans@...ia.com>; Bob Briscoe <research@...briscoe.net>; Henrik Steen <henrist@...rist.net>
> Subject: Re: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> On Sun, 16 Mar 2025 16:39:17 +0100
> chia-yu.chang@...ia-bell-labs.com wrote:
> 
> > +static int try_get_percentage(int *val, const char *arg, int base) {
> > +     long res;
> > +     char *ptr;
> > +
> > +     if (!arg || !*arg)
> > +             return -1;
> > +     res = strtol(arg, &ptr, base);
> > +     if (!ptr || ptr == arg || (*ptr && strcmp(ptr, "%")))
> > +             return -1;
> > +     if (res == ULONG_MAX && errno == ERANGE)
> > +             return -1;
> > +     if (res < 0 || res > 100)
> > +             return -1;
> > +
> > +     *val = res;
> > +     return 0;
> > +}
> > +
> 
> I wonder if dualpi2 and netem could share some code on handling scaled percentage values.

Thanks for the feedback, and I would reuse "parse_percent" in tc/tc_util.c in the next version.

Since the scaling factor of percentage in netem is to UINT32_MAX, while in dualpi2 is between 0 to 100.