netdev - Re: [PATCH net-next 2/2] tcp/dccp: remove icsk->icsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+t82W=WbX59b-kPVwcZFvd7=xuEE9BoV__5yXQznjGOg@mail.gmail.com>
Date: Tue, 18 Mar 2025 15:56:02 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, eric.dumazet@...il.com, horms@...nel.org, 
	kuba@...nel.org, ncardwell@...gle.com, netdev@...r.kernel.org, 
	pabeni@...hat.com
Subject: Re: [PATCH net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout

On Mon, Mar 17, 2025 at 9:28 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Mon, 17 Mar 2025 15:14:01 +0000
> > icsk->icsk_ack.timeout can be replaced by icsk->csk_delack_timer.expires
> >
> > This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

I will send a V2, rebased after "tcp: cache RTAX_QUICKACK metric in a
hot cache line"

Thanks.