netdev - Re: [PATCH v1 net-next 1/4] af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9n8w-6nXiBUI20T@LQ3V64L9R2>
Date: Tue, 18 Mar 2025 16:07:47 -0700
From: Joe Damato <jdamato@...tly.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 1/4] af_unix: Sort headers.

On Mon, Mar 17, 2025 at 08:48:48PM -0700, Kuniyuki Iwashima wrote:
> This is a prep patch to make the following changes cleaner.
> 
> No functional change intended.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
>  include/net/af_unix.h      |  4 +--
>  net/unix/af_unix.c         | 62 +++++++++++++++++++-------------------
>  net/unix/diag.c            | 15 ++++-----
>  net/unix/garbage.c         | 17 +++++------
>  net/unix/sysctl_net_unix.c |  1 -
>  net/unix/unix_bpf.c        |  4 +--
>  6 files changed, 51 insertions(+), 52 deletions(-)

[...]

> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 7f8f3859cdb3..1ff0ac99f3f3 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c

[...]

> +#include <linux/in.h>
>  #include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/mount.h>
> +#include <linux/namei.h>
> +#include <linux/net.h>
> +#include <linux/netdevice.h>
>  #include <linux/poll.h>
> +#include <linux/proc_fs.h>
>  #include <linux/rtnetlink.h>
> -#include <linux/mount.h>
> -#include <net/checksum.h>
> +#include <linux/sched/signal.h>

Not sure what the sorting rules are, but I was wondering if maybe
"linux/sched/*.h" should come after linux/*.h and not sorted within
linux/s*.h ?

>  #include <linux/security.h>
> +#include <linux/seq_file.h>
> +#include <linux/signal.h>
> +#include <linux/skbuff.h>
> +#include <linux/slab.h>
> +#include <linux/socket.h>
> +#include <linux/sockios.h>