netdev - Re: [PATCH net] net: lwtunnel: fix recursion loops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2fb553a-1bb3-46b6-91de-da7f185020a3@uliege.be>
Date: Tue, 18 Mar 2025 06:29:30 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH net] net: lwtunnel: fix recursion loops

On 3/12/25 11:32, Justin Iurman wrote:
> Different kind of loops in most of lwtunnel users were fixed by some
> recent patches. This patch acts as a parachute, catch all solution, by
> detecting any use cases with recursion and taking care of them (e.g., a
> loop between routes). This is applied to lwtunnel_input(),
> lwtunnel_output(), and lwtunnel_xmit().
> 
> Fixes: ffce41962ef6 ("lwtunnel: support dst output redirect function")
> Fixes: 2536862311d2 ("lwt: Add support to redirect dst.input")
> Fixes: 14972cbd34ff ("net: lwtunnel: Handle fragmentation")
> Closes: https://lore.kernel.org/netdev/2bc9e2079e864a9290561894d2a602d6@akamai.com/
> Cc: Roopa Prabhu <roopa@...dia.com>
> Cc: Andrea Mayer <andrea.mayer@...roma2.it>
> Cc: Stefano Salsano <stefano.salsano@...roma2.it>
> Cc: Ahmed Abdelsalam <ahabdels.dev@...il.com>
> Cc: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Justin Iurman <justin.iurman@...ege.be>
> ---
>   net/core/lwtunnel.c | 65 ++++++++++++++++++++++++++++++++++++---------
>   net/core/lwtunnel.h | 42 +++++++++++++++++++++++++++++
>   2 files changed, 95 insertions(+), 12 deletions(-)
>   create mode 100644 net/core/lwtunnel.h

Just for clarity, you can ignore this patch. It is now included in a 
series [1] (see patch #1 of the series) and has been modified based on 
feedback received in this thread.

Thanks!

   [1] 
https://lore.kernel.org/all/20250314120048.12569-1-justin.iurman@uliege.be/