netdev - Re: [v5 PATCH 10/14] crypto: acomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9qVDFAzse7y3zLa@gondor.apana.org.au>
Date: Wed, 19 Mar 2025 17:57:32 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Cc: Richard Weinberger <richard@....at>,
	Zhihao Cheng <chengzhihao1@...wei.com>,
	linux-mtd@...ts.infradead.org,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Pavel Machek <pavel@....cz>, linux-pm@...r.kernel.org,
	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org
Subject: Re: [v5 PATCH 10/14] crypto: acomp - Add support for folios

On Sat, Mar 15, 2025 at 06:30:40PM +0800, Herbert Xu wrote:
>
> -		n = slen / PAGE_SIZE;
> -		n += (offset_in_page(slen) + soff - 1) / PAGE_SIZE;
> -		if (slen <= req->src->length &&
> -		    (!PageHighMem(nth_page(spage, n)) ||
> -		     size_add(soff, slen) <= PAGE_SIZE))
> +			spage = nth_page(spage, soff / PAGE_SIZE);
> +			soff = offset_in_page(soff);
> +
> +			n = slen / PAGE_SIZE;
> +			n += (offset_in_page(slen) + soff - 1) / PAGE_SIZE;
> +			if (PageHighMem(nth_page(spage, n)) &&
> +			    size_add(soff, slen) <= PAGE_SIZE)
> +				break;

This should of course be

			size_add(soff, slen) > PAGE_SIZE

> +			if (PageHighMem(dpage + n) &&
> +			    size_add(doff, dlen) <= PAGE_SIZE)

Ditto.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt