netdev - Re: [PATCH net-next 09/11] net: designate XSK pool pointers in queues as "ops protected"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d8c2b59-44ba-4444-9cd5-5ba70ba55f32@redhat.com>
Date: Wed, 19 Mar 2025 22:51:05 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org, sdf@...ichev.me
Subject: Re: [PATCH net-next 09/11] net: designate XSK pool pointers in queues
 as "ops protected"

On 3/12/25 11:35 PM, Jakub Kicinski wrote:
> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
> index 14716ad3d7bc..60b3adb7b2d7 100644
> --- a/net/xdp/xsk_buff_pool.c
> +++ b/net/xdp/xsk_buff_pool.c
> @@ -279,9 +279,12 @@ static void xp_release_deferred(struct work_struct *work)
>  {
>  	struct xsk_buff_pool *pool = container_of(work, struct xsk_buff_pool,
>  						  work);
> +	struct net_device *netdev = pool->netdev;
>  
>  	rtnl_lock();
> +	netdev_lock_ops(netdev);

I agree with Stan, NULL ptr deref. looks possible here.

/P