netdev - Re: [PATCH net] net: mvpp2: Prevent parser TCAM memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16143c70-de5a-4f30-ad29-eae33d2e5b0b@lunn.ch>
Date: Thu, 20 Mar 2025 14:14:16 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Tobias Waldekranz <tobias@...dekranz.com>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>, davem@...emloft.net,
	kuba@...nel.org, marcin.s.wojtas@...il.com, linux@...linux.org.uk,
	edumazet@...gle.com, pabeni@...hat.com,
	ezequiel.garcia@...e-electrons.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: mvpp2: Prevent parser TCAM memory corruption

> We still need to disable bottom halves though, right?  Because otherwise
> we could reach mvpp2_set_rx_mode() from net-rx by processing an IGMP/MLD
> frame, for example.

Ah, that answers the question i was asking myself. Why does RTNL not
cover this...

Maybe the design was that RTNL is supposed to protect this, but things
are happening outside of it? It would of helped if the code had put in
some ASSERT_RTNL() calls to both indicate this was the idea, and to
find cases where it was not actually true.

	Andrew