netdev - Re: [PATCH net-next] docs: fix the path of example code and example commands for device memory TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izNn+D=E0E2y5-gCGyyKSJgxTq63K-kthjFCwhQd_Tw0tA@mail.gmail.com>
Date: Thu, 20 Mar 2025 10:59:50 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Yui Washizu <yui.washidu@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, horms@...nel.org, corbet@....net, sdf@...ichev.me, 
	linux-doc@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] docs: fix the path of example code and example
 commands for device memory TCP

On Mon, Mar 17, 2025 at 11:14 PM Yui Washizu <yui.washidu@...il.com> wrote:
>
> This updates the old path and fixes the description of unavailable options.
>
> Signed-off-by: Yui Washizu <yui.washidu@...il.com>

Thank you, I think when I updated some of the implementations of
ncdevmem I didn't update the docs:

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

> ---
>  Documentation/networking/devmem.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/networking/devmem.rst b/Documentation/networking/devmem.rst
> index d95363645331..eb678ca45496 100644
> --- a/Documentation/networking/devmem.rst
> +++ b/Documentation/networking/devmem.rst
> @@ -256,7 +256,7 @@ Testing
>  =======
>
>  More realistic example code can be found in the kernel source under
> -``tools/testing/selftests/net/ncdevmem.c``
> +``tools/testing/selftests/drivers/net/hw/ncdevmem.c``
>
>  ncdevmem is a devmem TCP netcat. It works very similarly to netcat, but
>  receives data directly into a udmabuf.
> @@ -268,8 +268,7 @@ ncdevmem has a validation mode as well that expects a repeating pattern of
>  incoming data and validates it as such. For example, you can launch
>  ncdevmem on the server by::
>
> -       ncdevmem -s <server IP> -c <client IP> -f eth1 -d 3 -n 0000:06:00.0 -l \
> -                -p 5201 -v 7
> +       ncdevmem -s <server IP> -c <client IP> -f <ifname> -l -p 5201 -v 7
>
>  On client side, use regular netcat to send TX data to ncdevmem process
>  on the server::
> --
> 2.43.5
>


-- 
Thanks,
Mina