netdev - Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320183858.GJ892515@horms.kernel.org>
Date: Thu, 20 Mar 2025 18:38:58 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...zon.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout

On Tue, Mar 18, 2025 at 03:43:59PM +0000, Eric Dumazet wrote:
> icsk->icsk_ack.timeout can be replaced by icsk->csk_delack_timer.expires
> 
> This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
> v2: rebase after "tcp: cache RTAX_QUICKACK metric in a hot cache line"

Hi Eric,

I hate to be a bore, but patch 2/2 does seem to apply to net-next.