netdev - Re: [v5 PATCH 11/14] xfrm: ipcomp: Use crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9vhBv2Jp0ABpZas@gondor.apana.org.au>
Date: Thu, 20 Mar 2025 17:33:58 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Cc: Richard Weinberger <richard@....at>,
	Zhihao Cheng <chengzhihao1@...wei.com>,
	linux-mtd@...ts.infradead.org,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Pavel Machek <pavel@....cz>, linux-pm@...r.kernel.org,
	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org
Subject: Re: [v5 PATCH 11/14] xfrm: ipcomp: Use crypto_acomp interface

On Sat, Mar 15, 2025 at 06:30:43PM +0800, Herbert Xu wrote:
>
> +	sg_init_table(dsg, dnfrags);
> +	total = 0;
> +	for (i = 0; i < dnfrags && total < dlen; i++) {
> +		struct page *page;
> +
> +		page = alloc_page(GFP_ATOMIC);
> +		if (!page)
> +			break;
> +		sg_set_page(dsg + i, page, PAGE_SIZE, 0);
> +		total += PAGE_SIZE;
> +	}
> +	if (!i)
> +		return ERR_PTR(-ENOMEM);
> +	sg_mark_end(dsg + i - 1);

This is missing a

	dlen = min(dlen, total);

> +
> +	acomp_request_set_params(req, sg, dsg, plen, dlen);

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt