netdev - Re: [PATCH v2 net] net: mvpp2: Prevent parser TCAM memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f2f66ae-b1ac-4c87-9215-c1b6949d62c4@lunn.ch>
Date: Fri, 21 Mar 2025 13:12:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Tobias Waldekranz <tobias@...dekranz.com>
Cc: davem@...emloft.net, kuba@...nel.org, maxime.chevallier@...tlin.com,
	marcin.s.wojtas@...il.com, linux@...linux.org.uk,
	edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] net: mvpp2: Prevent parser TCAM memory corruption

> +static int mvpp2_prs_init_from_hw_unlocked(struct mvpp2 *priv,
> +					   struct mvpp2_prs_entry *pe, int tid)
>  {
>  	int i;
>  

This is called from quite a few places, and the locking is not always
obvious. Maybe add

__must_hold(&priv->prs_spinlock)

so sparse can verify the call paths ?

	Andrew