netdev - Re: [PATCH] net: Fix the devmem sock opts and msgs for parisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoBhKBhXxN0H0dmZVuD5x=cnUaZH0ZMhb2WM9ndDsqJsuQ@mail.gmail.com>
Date: Fri, 21 Mar 2025 23:16:59 +0700
From: Jason Xing <kerneljasonxing@...il.com>
To: Pranjal Shrivastava <praan@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, linux-parisc@...r.kernel.org, 
	Willem de Bruijn <willemb@...gle.com>, Mina Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH] net: Fix the devmem sock opts and msgs for parisc

On Fri, Mar 21, 2025 at 5:39 PM Pranjal Shrivastava <praan@...gle.com> wrote:
>
> The devmem socket options and socket control message definitions
> introduced in the TCP devmem series[1] incorrectly continued the socket
> definitions for arch/parisc.
>
> The UAPI change seems safe as there are currently no drivers that
> declare support for devmem TCP RX via PP_FLAG_ALLOW_UNREADABLE_NETMEM.
> Hence, fixing this UAPI should be safe.
>
> Fix the devmem socket options and socket control message definitions to
> reflect the series followed by arch/parisc.
>
> [1]
> https://lore.kernel.org/lkml/20240910171458.219195-10-almasrymina@google.com/
>
> Fixes: 8f0b3cc9a4c10 ("tcp: RX path for devmem TCP")
> Signed-off-by: Pranjal Shrivastava <praan@...gle.com>

When I did the review for [1], I noticed that. Regarding to the patch
itself, feel free to add my tag in the next revision:
Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

[1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=23b763302ce0

Thanks,
Jason


> ---
>  arch/parisc/include/uapi/asm/socket.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/parisc/include/uapi/asm/socket.h b/arch/parisc/include/uapi/asm/socket.h
> index aa9cd4b951fe..96831c988606 100644
> --- a/arch/parisc/include/uapi/asm/socket.h
> +++ b/arch/parisc/include/uapi/asm/socket.h
> @@ -132,16 +132,16 @@
>  #define SO_PASSPIDFD           0x404A
>  #define SO_PEERPIDFD           0x404B
>
> -#define SO_DEVMEM_LINEAR       78
> -#define SCM_DEVMEM_LINEAR      SO_DEVMEM_LINEAR
> -#define SO_DEVMEM_DMABUF       79
> -#define SCM_DEVMEM_DMABUF      SO_DEVMEM_DMABUF
> -#define SO_DEVMEM_DONTNEED     80
> -
>  #define SCM_TS_OPT_ID          0x404C
>
>  #define SO_RCVPRIORITY         0x404D
>
> +#define SO_DEVMEM_LINEAR       0x404E
> +#define SCM_DEVMEM_LINEAR      SO_DEVMEM_LINEAR
> +#define SO_DEVMEM_DMABUF       0x404F
> +#define SCM_DEVMEM_DMABUF      SO_DEVMEM_DMABUF
> +#define SO_DEVMEM_DONTNEED     0x4050
> +
>  #if !defined(__KERNEL__)
>
>  #if __BITS_PER_LONG == 64
> --
> 2.49.0.395.g12beb8f557-goog
>
>