netdev - Re: [PATCH v4 5/6] pds_fwctl: add rpc and query support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250321235026.GD206770@nvidia.com>
Date: Fri, 21 Mar 2025 20:50:26 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: "Nelson, Shannon" <shannon.nelson@....com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	andrew.gospodarek@...adcom.com, aron.silverton@...cle.com,
	dan.j.williams@...el.com, daniel.vetter@...ll.ch,
	dave.jiang@...el.com, dsahern@...nel.org,
	gregkh@...uxfoundation.org, hch@...radead.org, itayavr@...dia.com,
	jiri@...dia.com, Jonathan.Cameron@...wei.com, kuba@...nel.org,
	lbloch@...dia.com, leonro@...dia.com, linux-cxl@...r.kernel.org,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	saeedm@...dia.com, brett.creeley@....com
Subject: Re: [PATCH v4 5/6] pds_fwctl: add rpc and query support

On Fri, Mar 21, 2025 at 09:59:32AM -0700, Nelson, Shannon wrote:
> diff --git a/drivers/fwctl/pds/main.c b/drivers/fwctl/pds/main.c
> index 6fedde2a962e..e50e1bbdff9a 100644
> --- a/drivers/fwctl/pds/main.c
> +++ b/drivers/fwctl/pds/main.c
> @@ -76,8 +76,7 @@ static int pdsfc_identify(struct pdsfc_dev *pdsfc)
>         int err;
> 
>         ident = dma_alloc_coherent(dev->parent, sizeof(*ident), &ident_pa, GFP_KERNEL);
> -       err = dma_mapping_error(dev->parent, ident_pa);
> -       if (err) {
> +       if (!ident) {
>                 dev_err(dev, "Failed to map ident buffer\n");
>                 return err;
x
err is uninitialized, it should just be -ENOMEM I think.

Anyhow I fixed it up, please let me know

Jason