netdev - Re: [PATCH net 2/3] net: dsa: sja1105: reject other RX filters than HWTSTAMP_FILTER_PTP_V2_L2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250321081724.GN892515@horms.kernel.org>
Date: Fri, 21 Mar 2025 08:17:24 +0000
From: Simon Horman <horms@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Richard Cochran <richardcochran@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net 2/3] net: dsa: sja1105: reject other RX filters than
 HWTSTAMP_FILTER_PTP_V2_L2_EVENT

On Tue, Mar 18, 2025 at 01:57:15PM +0200, Vladimir Oltean wrote:
> This is all that we can support timestamping, so we shouldn't accept
> anything else. Also see sja1105_hwtstamp_get().
> 
> To avoid erroring out in an inconsistent state, operate on copies of
> priv->hwts_rx_en and priv->hwts_tx_en, and write them back when nothing
> else can fail anymore.
> 
> Fixes: a602afd200f5 ("net: dsa: sja1105: Expose PTP timestamping ioctls to userspace")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Simon Horman <horms@...nel.org>