netdev - Re: [PATCH net-next v2 0/4] net/mlx5: Expose additional devlink dev info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26aed6e2-a728-4084-a31a-37b88fe3e24b@gmail.com>
Date: Sun, 23 Mar 2025 14:00:30 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com,
 parav@...dia.com
Subject: Re: [PATCH net-next v2 0/4] net/mlx5: Expose additional devlink dev
 info



On 20/03/2025 10:59, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> This patchset aims to expose couple of already defined serial numbers
> for mlx5 driver.
> 
> On top of that, it introduces new field, "function.uid" and exposes
> that for mlx5 driver.
> 
> Example:
> 
> $ devlink dev info
> pci/0000:08:00.0:
>    driver mlx5_core
>    serial_number e4397f872caeed218000846daa7d2f49
>    board.serial_number MT2314XZ00YA
>    function.uid MT2314XZ00YAMLNXS0D0F0
>    versions:
>        fixed:
>          fw.psid MT_0000000894
>        running:
>          fw.version 28.41.1000
>          fw 28.41.1000
>        stored:
>          fw.version 28.41.1000
>          fw 28.41.1000
> auxiliary/mlx5_core.eth.0:
>    driver mlx5_core.eth
> pci/0000:08:00.1:
>    driver mlx5_core
>    serial_number e4397f872caeed218000846daa7d2f49
>    board.serial_number MT2314XZ00YA
>    function.uid MT2314XZ00YAMLNXS0D0F1
>    versions:
>        fixed:
>          fw.psid MT_0000000894
>        running:
>          fw.version 28.41.1000
>          fw 28.41.1000
>        stored:
>          fw.version 28.41.1000
>          fw 28.41.1000
> auxiliary/mlx5_core.eth.1:
>    driver mlx5_core.eth
> 
> The first patch just adds a small missing bit in devlink ynl spec.
> 
> ---
> v1->v2:
> - patch#2:
>    - fixed possibly uninitialized variable "err"
> 
> Jiri Pirko (4):
>    ynl: devlink: add missing board-serial-number
>    net/mlx5: Expose serial numbers in devlink info
>    devlink: add function unique identifier to devlink dev info
>    net/mlx5: Expose function UID in devlink info
> 
>   Documentation/netlink/specs/devlink.yaml      |  5 ++
>   .../networking/devlink/devlink-info.rst       |  5 ++
>   .../net/ethernet/mellanox/mlx5/core/devlink.c | 62 +++++++++++++++++++
>   include/net/devlink.h                         |  2 +
>   include/uapi/linux/devlink.h                  |  2 +
>   net/devlink/dev.c                             |  9 +++
>   6 files changed, 85 insertions(+)
> 

For the mlx5 parts:
Acked-by: Tariq Toukan <tariqt@...dia.com>

Thanks,
Tariq