netdev - Re: [PATCH net-next] ipv6: fix _DEVADD() and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250323165345.GS892515@horms.kernel.org>
Date: Sun, 23 Mar 2025 16:53:45 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next] ipv6: fix _DEVADD() and _DEVUPD() macros

On Wed, Mar 19, 2025 at 09:25:16PM +0000, Eric Dumazet wrote:
> ip6_rcv_core() is using:
> 
> 	__IP6_ADD_STATS(net, idev,
> 			IPSTATS_MIB_NOECTPKTS +
> 				(ipv6_get_dsfield(hdr) & INET_ECN_MASK),
> 			max_t(unsigned short, 1, skb_shinfo(skb)->gso_segs));
> 
> This is currently evaluating both expressions twice.
> 
> Fix _DEVADD() and _DEVUPD() macros to evaluate their arguments once.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>