lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250324014639.4105332-1-dw@davidwei.uk>
Date: Sun, 23 Mar 2025 18:46:39 -0700
From: David Wei <dw@...idwei.uk>
To: netdev@...r.kernel.org
Cc: Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Stanislav Fomichev <stfomichev@...il.com>
Subject: [PATCH net] net: page_pool: replace ASSERT_RTNL() in page_pool_init()

Replace a stray ASSERT_RTNL() in page_pool_init() with
netdev_assert_locked().

Fixes: 1d22d3060b9b ("net: drop rtnl_lock for queue_mgmt operations")
Signed-off-by: David Wei <dw@...idwei.uk>
---
 net/core/page_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index f5e908c9e7ad..2f469b02ea31 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -281,7 +281,7 @@ static int page_pool_init(struct page_pool *pool,
 		 * configuration doesn't change while we're initializing
 		 * the page_pool.
 		 */
-		ASSERT_RTNL();
+		netdev_assert_locked(params->netdev);
 		rxq = __netif_get_rx_queue(pool->slow.netdev,
 					   pool->slow.queue_idx);
 		pool->mp_priv = rxq->mp_params.mp_priv;
-- 
2.47.1


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ