netdev - Re: [PATCH 2/2] dt-bindings: net: mscc,vsc7514-switch: allow specifying 'phys' for switch ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174282607911.6262.15261935260960976141.robh@kernel.org>
Date: Mon, 24 Mar 2025 09:21:21 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Rasmus Villemoes <ravi@...vas.dk>
Cc: Colin Foster <colin.foster@...advantage.com>, netdev@...r.kernel.org, 
 Vladimir Oltean <vladimir.oltean@....com>, 
 Felix Blix Everberg <felix.blix@...vas.dk>, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: net: mscc,vsc7514-switch: allow
 specifying 'phys' for switch ports

On Mon, 24 Mar 2025 09:55:06 +0100, Rasmus Villemoes wrote:
> Ports that use SGMII / QSGMII to interface to external phys (or as
> fixed-link to a cpu mac) need to configure the internal SerDes
> interface appropriately. Allow an optional 'phys' property to describe
> those relationships.
> 
> Signed-off-by: Rasmus Villemoes <ravi@...vas.dk>
> ---
>  .../devicetree/bindings/net/mscc,vsc7514-switch.yaml      | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml:40:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml:40:1: found a tab character that violates indentation
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mscc,ocelot.yaml:
while scanning a plain scalar
  in "<unicode string>", line 39, column 21
found a tab character that violates indentation
  in "<unicode string>", line 40, column 1
make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/mscc,vsc7514-switch.example.dts'
Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml:40:1: found a tab character that violates indentation
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/mscc,vsc7514-switch.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250324085506.55916-3-ravi@prevas.dk

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.