netdev - Re: [PATCH 1/2] Revert "dt-bindings: net: mscc,vsc7514-switch: Simplify DSA and switch references"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324144149.GB11614-robh@kernel.org>
Date: Mon, 24 Mar 2025 09:41:49 -0500
From: Rob Herring <robh@...nel.org>
To: Rasmus Villemoes <ravi@...vas.dk>
Cc: Colin Foster <colin.foster@...advantage.com>,
	devicetree@...r.kernel.org,
	Felix Blix Everberg <felix.blix@...vas.dk>, netdev@...r.kernel.org,
	Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH 1/2] Revert "dt-bindings: net: mscc,vsc7514-switch:
 Simplify DSA and switch references"

On Mon, Mar 24, 2025 at 09:55:05AM +0100, Rasmus Villemoes wrote:
> The commit log for commit 7c93392d754e ("dt-bindings: net:
> mscc,vsc7514-switch: Simplify DSA and switch references") says
> 
>   The mscc,vsc7514-switch schema doesn't add any custom port
>   properties
> 
> In preparation for adding such a custom port property, revert that
> commit.

This leaves the schema in wrong state until the next patch and doesn't 
really stand on its own. So I would combine the 2 patches.

> 
> Signed-off-by: Rasmus Villemoes <ravi@...vas.dk>
> ---
>  .../bindings/net/mscc,vsc7514-switch.yaml          | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> index 86a9c3fc76c89..07de52a3a2951 100644
> --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> @@ -24,7 +24,7 @@ allOf:
>          compatible:
>            const: mscc,vsc7514-switch
>      then:
> -      $ref: ethernet-switch.yaml#/$defs/ethernet-ports
> +      $ref: ethernet-switch.yaml#
>        required:
>          - interrupts
>          - interrupt-names
> @@ -33,18 +33,28 @@ allOf:
>            minItems: 21
>          reg-names:
>            minItems: 21
> +        ethernet-ports:
> +          patternProperties:
> +            "^port@[0-9a-f]+$":
> +              $ref: ethernet-switch-port.yaml#
> +              unevaluatedProperties: false
>  
>    - if:
>        properties:
>          compatible:
>            const: mscc,vsc7512-switch
>      then:
> -      $ref: /schemas/net/dsa/dsa.yaml#/$defs/ethernet-ports
> +      $ref: /schemas/net/dsa/dsa.yaml#
>        properties:
>          reg:
>            maxItems: 20
>          reg-names:
>            maxItems: 20
> +        ethernet-ports:
> +          patternProperties:
> +            "^port@[0-9a-f]+$":
> +              $ref: /schemas/net/dsa/dsa-port.yaml#
> +              unevaluatedProperties: false
>  
>  properties:
>    compatible:
> -- 
> 2.49.0
>