netdev - Re: [RFC PATCH] wifi: free SKBTX_WIFI_STATUS skb tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoBHbK=xDEp7RHqUHxSZqNOcd7kxAEdPC7aZq8RaWtDa0Q@mail.gmail.com>
Date: Tue, 25 Mar 2025 00:59:48 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] wifi: free SKBTX_WIFI_STATUS skb tx_flags flag

On Tue, Mar 25, 2025 at 12:56 AM Johannes Berg
<johannes@...solutions.net> wrote:
>
> On Tue, 2025-03-25 at 00:53 +0800, Jason Xing wrote:
> >
> > Thanks for working on this. After net-next is open, I will use this
> > bit to finish the bpf timestamping in the rx path :)
>
> :)
>
> > > --- a/include/linux/skbuff.h
> > > +++ b/include/linux/skbuff.h
> > > @@ -481,9 +481,6 @@ enum {
> > >         /* reserved */
> > >         SKBTX_RESERVED = 1 << 3,
> >
> > It might conflict with the bluetooth commit [1], I presume.
> >
> > [1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=c6c3dc495a6ce5b9dfed4df08c3220207e7103bd
>
> True, just context though, we can deal with that.
>
> > >
> > > -       /* generate wifi status information (where possible) */
> > > -       SKBTX_WIFI_STATUS = 1 << 4,
> > > -
> >
> > Better use SKBTX_RESERVED. No strong preference here since I'm going to use it.
>
> I can't have two called SKBTX_RESERVED, but I'm not sure it's worth
> renaming it rather than removing? No strong opinion though. The context
> conflict will happen either way ;)

Sure, we can ignore it. As I mentioned, this released bit will be used soon :)

>
> johannes
>