netdev - Re: [PATCH net-next] selftests: drv-net: rss_input_xfrm: Check test prerequisites before running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2e6f293-9f93-4d07-9ba8-9f1891c68162@nvidia.com>
Date: Mon, 24 Mar 2025 19:53:54 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
 Nimrod Oren <noren@...dia.com>
Subject: Re: [PATCH net-next] selftests: drv-net: rss_input_xfrm: Check test
 prerequisites before running

On 24/03/2025 19:19, Jakub Kicinski wrote:
> On Mon, 17 Mar 2025 14:31:49 +0200 Gal Pressman wrote:
>> +    try:
>> +        cmd("hash socat", host=cfg.remote)
>> +    except CmdExitFailure:
>> +        raise KsftSkipEx("socat not installed on remote")
> 
> I'm not familiar with "hash", would using
> 
> 	cfg.require_cmd("socat", remote=True)
> 
> work? IOW we do have a helper for this sort of checking.

Nice, I should've seen this helper, will change, thanks.