netdev - Re: [PATCH] net: au1000_eth: Mark au1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z+D1NpUDCsIZLAEP@mev-dev.igk.intel.com>
Date: Mon, 24 Mar 2025 07:01:26 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Johan Korsnes <johan.korsnes@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] net: au1000_eth: Mark au1000_ReleaseDB() static

On Sun, Mar 23, 2025 at 08:04:50PM +0100, Johan Korsnes wrote:
> This fixes the following build warning:
> ```
> drivers/net/ethernet/amd/au1000_eth.c:574:6: warning: no previous prototype for 'au1000_ReleaseDB' [-Wmissing-prototypes]
>   574 | void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB)
>       |      ^~~~~~~~~~~~~~~~
> ```
> 
> Signed-off-by: Johan Korsnes <johan.korsnes@...il.com>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> ---
>  drivers/net/ethernet/amd/au1000_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c
> index 0671a066913b..9d35ac348ebe 100644
> --- a/drivers/net/ethernet/amd/au1000_eth.c
> +++ b/drivers/net/ethernet/amd/au1000_eth.c
> @@ -571,7 +571,7 @@ static struct db_dest *au1000_GetFreeDB(struct au1000_private *aup)
>  	return pDB;
>  }
>  
> -void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB)
> +static void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB)
>  {
>  	struct db_dest *pDBfree = aup->pDBfree;
>  	if (pDBfree)

Thanks for fixing it
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

You didn't specify the tree (net vs net-next in [PATCH ...]). If you
want it to go to net you will need fixes tag, if to net-next it is fine.

> -- 
> 2.49.0