netdev - Re: [PATCH iwl-next] ice: add a separate Rx handler for flow director commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3022053-18a9-45fe-af14-cbcede33e94f@intel.com>
Date: Mon, 24 Mar 2025 11:07:01 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Michal Kubiak <michal.kubiak@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <maciej.fijalkowski@...el.com>, <netdev@...r.kernel.org>, "Michal
 Swiatkowski" <michal.swiatkowski@...el.com>
Subject: Re: [PATCH iwl-next] ice: add a separate Rx handler for flow director
 commands

On 3/21/25 16:13, Michal Kubiak wrote:
> The "ice" driver implementation uses the control VSI to handle
> the flow director configuration for PFs and VFs.
> 
> Unfortunately, although a separate VSI type was created to handle flow
> director queues, the Rx queue handler was shared between the flow
> director and a standard NAPI Rx handler.
> 
> Such a design approach was not very flexible. First, it mixed hotpath
> and slowpath code, blocking their further optimization. It also created
> a huge overkill for the flow director command processing, which is
> descriptor-based only, so there is no need to allocate Rx data buffers.
> 
> For the above reasons, implement a separate Rx handler for the control
> VSI. Also, remove from the NAPI handler the code dedicated to
> configuring the flow director rules on VFs.
> Do not allocate Rx data buffers to the flow director queues because
> their processing is descriptor-based only.
> Finally, allow Rx data queues to be allocated only for VSIs that have
> netdev assigned to them.
> 
> This handler splitting approach is the first step in converting the
> driver to use the Page Pool (which can only be used for data queues).
> 
> Test hints:
>    1. Create a VF for any PF managed by the ice driver.
>    2. In a loop, add and delete flow director rules for the VF, e.g.:
> 
>         for i in {1..128}; do
>             q=$(( i % 16 ))
>             ethtool -N ens802f0v0 flow-type tcp4 dst-port "$i" action "$q"
>         done
> 
>         for i in {0..127}; do
>             ethtool -N ens802f0v0 delete "$i"
>         done
> 
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Suggested-by: Michal Swiatkowski <michal.swiatkowski@...el.com>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Michal Kubiak <michal.kubiak@...el.com>
Thank you, a very nice improvement

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>