netdev - Re: [PATCH bpf-next v4 2/2] selftests/xsk: Add tail adjustment tests and support check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <764f5e7a-4188-4952-9122-62d5bde3bc72@bootlin.com>
Date: Mon, 24 Mar 2025 13:32:25 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Tushar Vyavahare <tushar.vyavahare@...el.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, bjorn@...nel.org,
 magnus.karlsson@...el.com, jonathan.lemon@...il.com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
 tirthendu.sarkar@...el.com, Alexis Lothoré
 <alexis.lothore@...tlin.com>
Subject: Re: [PATCH bpf-next v4 2/2] selftests/xsk: Add tail adjustment tests
 and support check

Hi Maciej

On 3/22/25 2:14 PM, Maciej Fijalkowski wrote:
> On Fri, Mar 21, 2025 at 12:54:19AM +0000, Tushar Vyavahare wrote:
>> Introduce tail adjustment functionality in xskxceiver using
>> bpf_xdp_adjust_tail(). Add `xsk_xdp_adjust_tail` to modify packet sizes
>> and drop unmodified packets. Implement `is_adjust_tail_supported` to check
>> helper availability. Develop packet resizing tests, including shrinking
>> and growing scenarios, with functions for both single-buffer and
>> multi-buffer cases. Update the test framework to handle various scenarios
>> and adjust MTU settings. These changes enhance the testing of packet tail
>> adjustments, improving AF_XDP framework reliability.
>>
>> Signed-off-by: Tushar Vyavahare <tushar.vyavahare@...el.com>
> 
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> 
> We carry the description of executed tests at the beginning of
> xskxceiver.c and you have not updated it with these adjust tail tests but
> it's not a show-stopper to me. I'm okay with current state of this patch.
> 
> Bastien, you probably would want to take into consideration these changes
> if they go in before your bigger work.
> 

Thanks for the pointer, I'll keep an eye on it.

Best regards,
Bastien