netdev - Re: [PATCH net-next 01/10] idpf: add initial PTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325054421.7e60e5ad@kernel.org>
Date: Tue, 25 Mar 2025 05:44:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org, Milena Olech
 <milena.olech@...el.com>, przemyslaw.kitszel@...el.com,
 karol.kolacinski@...el.com, richardcochran@...il.com, Alexander Lobakin
 <aleksander.lobakin@...el.com>, Vadim Fedorenko
 <vadim.fedorenko@...ux.dev>, Willem de Bruijn <willemb@...gle.com>, Mina
 Almasry <almasrymina@...gle.com>, Samuel Salin <Samuel.salin@...el.com>
Subject: Re: [PATCH net-next 01/10] idpf: add initial PTP support

On Tue, 18 Mar 2025 09:13:16 -0700 Tony Nguyen wrote:
> From: Milena Olech <milena.olech@...el.com>
> 
> PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the
> capabilities recognition. Initial PTP support includes PTP initialization
> and registration of the clock.
> 
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Tested-by: Mina Almasry <almasrymina@...gle.com>
> Signed-off-by: Milena Olech <milena.olech@...el.com>
> Tested-by: Samuel Salin <Samuel.salin@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Would be great to see a review tag from Jake on these :(

> +#if IS_ENABLED(CONFIG_PTP_1588_CLOCK)
> +int idpf_ptp_init(struct idpf_adapter *adapter);
> +void idpf_ptp_release(struct idpf_adapter *adapter);
> +#else /* CONFIG_PTP_1588_CLOCK */
> +static inline int idpf_ptp_init(struct idpf_adapter *adapter)
> +{
> +	return 0;
> +}
> +
> +static inline void idpf_ptp_release(struct idpf_adapter *adapter) { }
> +#endif /* CONFIG_PTP_1588_CLOCK */
> +#endif /* _IDPF_PTP_H */

You add an unusual number of ifdefs for CONFIG_PTP_1588_CLOCK.
Is this really necessary? What breaks if 1588 is not enabled?