netdev - Re: [PATCH net-next v2 01/11] net: bubble up taking netdev instance lock to callers of net_devmem_unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izMOsOjerQ43gfPGbMoBgK5bsRkYGED3dSsZJW8JoVvppw@mail.gmail.com>
Date: Mon, 24 Mar 2025 22:19:23 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, sdf@...ichev.me
Subject: Re: [PATCH net-next v2 01/11] net: bubble up taking netdev instance
 lock to callers of net_devmem_unbind_dmabuf()

On Mon, Mar 24, 2025 at 3:46 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> A recent commit added taking the netdev instance lock
> in netdev_nl_bind_rx_doit(), but didn't remove it in
> net_devmem_unbind_dmabuf() which it calls from an error path.
> Always expect the callers of net_devmem_unbind_dmabuf() to
> hold the lock. This is consistent with net_devmem_bind_dmabuf().
>
> (Not so) coincidentally this also protects mp_param with the instance
> lock, which the rest of this series needs.
>
> Fixes: 1d22d3060b9b ("net: drop rtnl_lock for queue_mgmt operations")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Sorry for not noticing this earlier.

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

--
Thanks,
Mina