netdev - Re: [RESEND,PATCH net-next v9 5/6] net: ngbe: add sriov function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250325152057.GS892515@horms.kernel.org>
Date: Tue, 25 Mar 2025 15:20:57 +0000
From: Simon Horman <horms@...nel.org>
To: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, jiawenwu@...stnetic.com,
	duanqiangwen@...-swift.com
Subject: Re: [RESEND,PATCH net-next v9 5/6] net: ngbe: add sriov function
 support

On Tue, Mar 25, 2025 at 10:36:00AM +0800, mengyuanlou@...-swift.com wrote:
> > 2025年3月25日 03:21，Simon Horman <horms@...nel.org> 写道：
> > On Mon, Mar 24, 2025 at 10:00:32AM +0800, Mengyuan Lou wrote:

...

> That’s right.
> > If so, I believe this addresses Jakub's concerns.
> > 
> > And given that we are at v9 and the last feedback of substance was the
> > above comment from Jakub, I think this looks good.
> > 
> > Reviewed-by: Simon Horman <horms@...nel.org>
> > 
> > But I would like to say that there could be some follow-up to align
> > the comment and the names of the handlers:
> > 
> > * "other" seems to be used as a synonym for "misc".
> >  Perhaps ngbe_msix_misc() ?
> > * "common" seems to only process "misc" interrupts.
> >  Perhaps __ngbe_msix_misc() ?
> > * msic seems to be a misspelling of misc.
> > 
> 
> 
> >> +static irqreturn_t ngbe_msix_misc(int __always_unused irq, void *data)
> >> +{
> >>  ...
> >> + return __ngbe_msix_misc(wx, eicr);
> >> +}
> >> +
> >> +static irqreturn_t ngbe_misc_and_queue(int __always_unused irq, void *data)
> >> +{
> >>  ...
> >> + return __ngbe_msix_misc(wx, eicr);
> 
> 
> if (wx->num_vfs == 7)
> 	err = request_irq(wx->msix_entry->vector,
> 			  ngbe_misc_and_queue, 0, netdev->name, wx);
> else
> 	err = request_irq(wx->msix_entry->vector,
> 			  ngbe_msix_misc, 0, netdev->name, wx);
> 
> It’s more appropriate.
> 
> Thanks！

Yes, thanks.

And I also think it would also be nice to rename ngbe_msix_common()
as __ngbe_msix_misc().

But please hold off with any updates or follow-up as net-next is now closed
for the merge window.

Link: https://lore.kernel.org/netdev/20250324075539.2b60eb42@kernel.org/

...