[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z-LXHKBKbW3NyOv1@krikkit>
Date: Tue, 25 Mar 2025 17:17:32 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
Willem de Bruijn <willemdebruijn.kernel@...il.com>,
David Ahern <dsahern@...nel.org>,
Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH net-next v2 4/5] udp_tunnel: avoid inconsistent local
variables usage
2025-03-21, 12:52:55 +0100, Paolo Abeni wrote:
> In setup_udp_tunnel_sock() 'sk' and 'sock->sk' are alias. The code
> I introduced there uses alternatively both variables, for no good
> reasons.
>
> Stick to 'sk' usage, to be consistent with the prior code.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>
--
Sabrina
Powered by blists - more mailing lists