netdev - Re: [PATCH net-next v2 08/11] net: make NETDEV_UNREGISTER and instance lock more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325100412.73b49ded@kernel.org>
Date: Tue, 25 Mar 2025 10:04:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Cosmin Ratiu <cratiu@...dia.com>
Cc: "davem@...emloft.net" <davem@...emloft.net>, "sdf@...ichev.me"
 <sdf@...ichev.me>, "horms@...nel.org" <horms@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH net-next v2 08/11] net: make NETDEV_UNREGISTER and
 instance lock more consistent

On Tue, 25 Mar 2025 12:17:15 +0000 Cosmin Ratiu wrote:
> > +	netdev_lock_ops(dev);
> >  	call_netdevice_notifier(nb, NETDEV_UNREGISTER, dev);
> > +	netdev_unlock_ops(dev);
> >  }  
> 
> This introduces a potential deadlock when changing a device namespace:
> do_setlink already locks the instance lock and
> call_netdevice_unregister_notifiers will then deadlock.

Thanks for catching, the notifiers need a closer look.
Let me apply the earlier patches (most importantly the fix)
and we'll see what shakes out as we address the outstanding
bugs in notifiers..