netdev - Re: [PATCH net-next 10/10] idpf: change the method for mailbox workqueue allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cc1c107-b244-468a-9692-3fa5206728fe@intel.com>
Date: Tue, 25 Mar 2025 14:08:56 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<andrew+netdev@...n.ch>, <netdev@...r.kernel.org>
CC: Milena Olech <milena.olech@...el.com>, <przemyslaw.kitszel@...el.com>,
	<karol.kolacinski@...el.com>, <richardcochran@...il.com>, Alexander Lobakin
	<aleksander.lobakin@...el.com>, Samuel Salin <Samuel.salin@...el.com>
Subject: Re: [PATCH net-next 10/10] idpf: change the method for mailbox
 workqueue allocation



On 3/18/2025 9:13 AM, Tony Nguyen wrote:
> From: Milena Olech <milena.olech@...el.com>
> 
> Since workqueues are created per CPU, the works scheduled to this
> workqueues are run on the CPU they were assigned. It may result in
> overloaded CPU that is not able to handle virtchnl messages in
> relatively short time. Allocating workqueue with WQ_UNBOUND and
> WQ_HIGHPRI flags allows scheduler to queue virtchl messages on less loaded
> CPUs, what eliminates delays.
> 
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Milena Olech <milena.olech@...el.com>
> Tested-by: Samuel Salin <Samuel.salin@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf_main.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_main.c b/drivers/net/ethernet/intel/idpf/idpf_main.c
> index 60bae3081035..022645f4fa9c 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_main.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_main.c
> @@ -198,9 +198,8 @@ static int idpf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		goto err_serv_wq_alloc;
>  	}
>  
> -	adapter->mbx_wq = alloc_workqueue("%s-%s-mbx",
> -					  WQ_UNBOUND | WQ_MEM_RECLAIM, 0,
> -					  dev_driver_string(dev),
> +	adapter->mbx_wq = alloc_workqueue("%s-%s-mbx", WQ_UNBOUND | WQ_HIGHPRI,
> +					  0, dev_driver_string(dev),
>  					  dev_name(dev));
>  	if (!adapter->mbx_wq) {
>  		dev_err(dev, "Failed to allocate mailbox workqueue\n");

I would reorder this patch first in the series, since it is required
(due to the way idpf communicates), but is not strictly related to PTP.

Thanks,
Jake