[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87o6xp5ptz.fsf@nvidia.com>
Date: Tue, 25 Mar 2025 12:09:18 +0100
From: Petr Machata <petrm@...dia.com>
To: Pablo Martin Medrano <pablmart@...hat.com>
CC: <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, "Eric
Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
Abeni" <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Shuah Khan
<shuah@...nel.org>, Petr Machata <petrm@...dia.com>, Filippo Storniolo
<fstornio@...hat.com>
Subject: Re: [PATCH net v4] selftests/net: big_tcp: return xfail on slow
machines
Pablo Martin Medrano <pablmart@...hat.com> writes:
> After debugging the following output for big_tcp.sh on a board:
>
> CLI GSO | GW GRO | GW GSO | SER GRO
> on on on on : [PASS]
> on off on off : [PASS]
> off on on on : [FAIL_on_link1]
> on on off on : [FAIL_on_link1]
>
> Davide Caratti found that by default the test duration 1s is too short
> in slow systems to reach the correct cwd size necessary for tcp/ip to
> generate at least one packet bigger than 65536 (matching the iptables
> match on length rule the test evaluates)
>
> This skips (with xfail) the aforementioned failing combinations when
> KSFT_MACHINE_SLOW is set. For that the test has been modified to use
> facilities from net/lib.sh.
>
> The new output for the test will look like this (example with a forced
> XFAIL)
>
> Testing for BIG TCP:
> CLI GSO | GW GRO | GW GSO | SER GRO
> TEST: on on on on [ OK ]
> TEST: on off on off [ OK ]
> TEST: off on on on [XFAIL]
>
> Fixes: a19747c3b9bf ("selftests: net: let big_tcp test cope with slow env")
> Suggested-by: Davide Caratti <dcaratti@...hat.com>
> Suggested-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Pablo Martin Medrano <pablmart@...hat.com>
Reviewed-by: Petr Machata <petrm@...dia.com>
Powered by blists - more mailing lists