[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <MN0PR11MB6232352A51F431A2E2E100959CA62@MN0PR11MB6232.namprd11.prod.outlook.com>
Date: Wed, 26 Mar 2025 06:11:33 +0000
From: "Kumari, Sweta" <sweta.kumari@...el.com>
To: Kurt Kanzenbach <kurt@...utronix.de>, "Nguyen, Anthony L"
<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
<przemyslaw.kitszel@...el.com>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, "Dumazet, Eric" <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Sebastian Andrzej Siewior
<bigeasy@...utronix.de>, "Damato, Joe" <jdamato@...tly.com>, Gerhard Engleder
<gerhard@...leder-embedded.com>, "intel-wired-lan@...ts.osuosl.org"
<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v3 2/4] igb: Link queues to
NAPI instances
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Kurt Kanzenbach
> Sent: Wednesday, March 19, 2025 3:57 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>; David S. Miller
> <davem@...emloft.net>; Dumazet, Eric <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Sebastian
> Andrzej Siewior <bigeasy@...utronix.de>; Damato, Joe
> <jdamato@...tly.com>; Gerhard Engleder <gerhard@...leder-
> embedded.com>; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org;
> Kurt Kanzenbach <kurt@...utronix.de>
> Subject: [Intel-wired-lan] [PATCH iwl-next v3 2/4] igb: Link queues to NAPI
> instances
>
> Link queues to NAPI instances via netdev-genl API. This is required to use
> XDP/ZC busy polling. See commit 5ef44b3cb43b ("xsk: Bring back busy polling
> support") for details.
>
> This also allows users to query the info with netlink:
>
> |$ ./tools/net/ynl/pyynl/cli.py --spec
> Documentation/netlink/specs/netdev.yaml \
> | --dump queue-get --json='{"ifindex": 2}'
> |[{'id': 0, 'ifindex': 2, 'napi-id': 8201, 'type': 'rx'},
> | {'id': 1, 'ifindex': 2, 'napi-id': 8202, 'type': 'rx'},
> | {'id': 2, 'ifindex': 2, 'napi-id': 8203, 'type': 'rx'},
> | {'id': 3, 'ifindex': 2, 'napi-id': 8204, 'type': 'rx'},
> | {'id': 0, 'ifindex': 2, 'napi-id': 8201, 'type': 'tx'},
> | {'id': 1, 'ifindex': 2, 'napi-id': 8202, 'type': 'tx'},
> | {'id': 2, 'ifindex': 2, 'napi-id': 8203, 'type': 'tx'},
> | {'id': 3, 'ifindex': 2, 'napi-id': 8204, 'type': 'tx'}]
>
> Add rtnl locking to PCI error handlers, because netif_queue_set_napi()
> requires the lock held.
>
> While at __igb_open() use RCT coding style.
>
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
> drivers/net/ethernet/intel/igb/igb.h | 2 ++
> drivers/net/ethernet/intel/igb/igb_main.c | 43
> +++++++++++++++++++++++++++----
> 2 files changed, 40 insertions(+), 5 deletions(-)
>
Tested-by: Sweta Kumari <sweta.kumari@...el.com>
Powered by blists - more mailing lists