netdev - Re: [PATCH net-next v4 2/4] net: Create separate gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAywjhRKL+iriK6X5D4UPHAZt4-rP7_rwYRAjjM30voVDaxmqg@mail.gmail.com>
Date: Thu, 27 Mar 2025 09:42:54 -0700
From: Samiullah Khawaja <skhawaja@...gle.com>
To: Joe Damato <jdamato@...tly.com>, Samiullah Khawaja <skhawaja@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, almasrymina@...gle.com, 
	willemb@...gle.com, mkarsten@...terloo.ca, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/4] net: Create separate gro_flush helper function

On Fri, Mar 21, 2025 at 10:16 AM Joe Damato <jdamato@...tly.com> wrote:
>
> On Fri, Mar 21, 2025 at 02:15:19AM +0000, Samiullah Khawaja wrote:
> > Move multiple copies of same code snippet doing `gro_flush` and
> > `gro_normal_list` into a separate helper function.
> >
> > Signed-off-by: Samiullah Khawaja <skhawaja@...gle.com>
>
> As mentioned in the previous review, I think this is missing a spot.
> the instance in napi_complete_done was not addressed as suggested
> previously.
Oops... I did that internally, but it seems I missed that spot during
rebase. Will send again.
>
> Is there any particular reason why that feedback was not addressed
> in this revision?