netdev - Re: [PATCH net v2 08/11] docs: net: document netdev notifier expectations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250327123403.6147088d@kernel.org>
Date: Thu, 27 Mar 2025 12:34:03 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com
Subject: Re: [PATCH net v2 08/11] docs: net: document netdev notifier
 expectations

On Thu, 27 Mar 2025 12:16:13 -0700 Jakub Kicinski wrote:
> > +* ``NETDEV_REGISTER``
> > +* ``NETDEV_UP``
> > +* ``NETDEV_UNREGISTER``  
> 
> Can I ask the obvious question - anything specific that's hard in also
> taking it in DOWN or just no time to investigate? Symmetry would be
> great.

Looking at patch 4 maybe we should do the opposite. This was my
original commit msg for locking UNREGISTER:

    net: make NETDEV_UNREGISTER and instance lock more consistent
    
    The NETDEV_UNREGISTER notifier gets called under the ops lock
    when device changes namespace but not during real unregistration.
    Take it consistently, XSK tries to poke at netdev queue state
    from this notifier.

So if the only caller currently under the lock is netns change, and 
we already split that to release the lock - maybe we can make
UNREGISTER always unlocked instead?