netdev - Re: [PATCH v8 net-next 5/5] net: ena: Add PHC documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250327111522.GA21758@unreal>
Date: Thu, 27 Mar 2025 13:15:22 +0200
From: Leon Romanovsky <leon@...nel.org>
To: "Arinzon, David" <darinzon@...zon.com>
Cc: Andrew Lunn <andrew@...n.ch>, David Woodhouse <dwmw2@...radead.org>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	"Machulsky, Zorik" <zorik@...zon.com>,
	"Matushevsky, Alexander" <matua@...zon.com>,
	"Bshara, Saeed" <saeedb@...zon.com>,
	"Wilson, Matt" <msw@...zon.com>,
	"Liguori, Anthony" <aliguori@...zon.com>,
	"Bshara, Nafea" <nafea@...zon.com>,
	"Schmeilin, Evgeny" <evgenys@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>,
	"Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>,
	"Kiyanovski, Arthur" <akiyano@...zon.com>,
	"Dagan, Noam" <ndagan@...zon.com>,
	"Bernstein, Amit" <amitbern@...zon.com>,
	"Allen, Neil" <shayagr@...zon.com>,
	"Ostrovsky, Evgeny" <evostrov@...zon.com>,
	"Tabachnik, Ofir" <ofirt@...zon.com>,
	"Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Gal Pressman <gal@...dia.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH v8 net-next 5/5] net: ena: Add PHC documentation

On Wed, Mar 26, 2025 at 03:32:00PM +0000, Arinzon, David wrote:
> > > > If you read the actual code in that patch, there's a hint though.
> > > > Because the actual process in ena_phc_enable_set() does the following:
> > > >
> > > > +   ena_destroy_device(adapter, false);
> > > > +   rc = ena_restore_device(adapter);
> > > >
> > > > Is that actually tearing down the whole netdev and recreating it
> > > > when the PHC enable is flipped?
> > >
> > > Well Jakub said it is a pure clock, not related to the netdev.
> 
> The PHC device is a PTP clock integrated with the networking device under the same PCI device.  
> As previously mentioned in this thread, enabling or disabling the ENA PHC requires reconfiguring the ENA network device, 
> which involves tearing down and recreating the netdev. 
> This necessitates having a separate control knob.

I appreciate the desire to keep everything in one place and provide
custom, vendor specific sysfs files. However, there is standard way
(auxbus??) to solve it without need to reinvent anything.

Thanks

> 
> Thanks,
> David
> 
> > 
> > So why are you ready to merge the code which is not netdev, doesn't have
> > any association with netdev and doesn't follow netdev semantics (no custom
> > sysfs files)?
> > 
> > Thanks