netdev - Re: [PATCH net v3 1/3] selftests: drv-net: replace the rpath helper with Path objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67e5efffb2b39_11b3cc2949e@willemb.c.googlers.com.notmuch>
Date: Thu, 27 Mar 2025 20:40:31 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 andrew+netdev@...n.ch, 
 horms@...nel.org, 
 sdf@...ichev.me, 
 willemdebruijn.kernel@...il.com, 
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net v3 1/3] selftests: drv-net: replace the rpath helper
 with Path objects

Jakub Kicinski wrote:
> The single letter + "path" helpers do not have many fans (see Link).
> Use a Path object with a better name. test_dir is the replacement
> for rpath(), net_lib_dir is a new path of the $ksft/net/lib directory.
> 
> The Path() class overloads the "/" operator and can be cast to string
> automatically, so to get a path to a file tests can do:
> 
>     path = env.test_dir / "binary"
> 
> Link: https://lore.kernel.org/CA+FuTSemTNVZ5MxXkq8T9P=DYm=nSXcJnL7CJBPZNAT_9UFisQ@mail.gmail.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>