netdev - Re: [PATCH net v2 06/11] netdevsim: add dummy device notifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-a7IYYTC_XEC8B6@mini-arch>
Date: Fri, 28 Mar 2025 08:07:13 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	netdev@...r.kernel.org, pabeni@...hat.com, sdf@...ichev.me
Subject: Re: [PATCH net v2 06/11] netdevsim: add dummy device notifiers

On 03/27, Kuniyuki Iwashima wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> Date: Thu, 27 Mar 2025 14:46:09 -0700
> > On Thu, 27 Mar 2025 14:04:06 -0700 Stanislav Fomichev wrote:
> > > > Can we register empty notifiers in nsim (just to make sure it has 
> > > > a callback) but do the validation in rtnl_net_debug.c
> > > > I guess we'd need to transform rtnl_net_debug.c a little,
> > > > make it less rtnl specific, compile under DEBUG_NET and ifdef
> > > > out the small rtnl parts?  
> > > 
> > > s/rtnl_net_debug.c/notifiers_debug.c/ + DEBUG_NET? Or I can keep the
> > > name and only do the DEBUG_NET part. 
> > 
> > I was thinking lock or locking as in net/core/lock_debug.c
> 
> Maybe lock.c (or netdev_lock.c like netdev_lock.h) and move all
> locking stuff (netdev_lock_type[], netdev_lock_pos(), etc) there
> later + ifdef where necessary ?

That might work as well, but will require move moving. Maybe I can
start with s/rtnl_net_debug.c/lock.c/ and the we can move the other
stuff separately?