netdev - Re: [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503300541.24wTsWWQ-lkp@intel.com>
Date: Sun, 30 Mar 2025 05:17:48 +0800
From: kernel test robot <lkp@...el.com>
To: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com,
	Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net v3 01/11] net: switch to netif_disable_lro in
 inetdev_init

Hi Stanislav,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/net-switch-to-netif_disable_lro-in-inetdev_init/20250330-030132
base:   net/main
patch link:    https://lore.kernel.org/r/20250329185704.676589-2-sdf%40fomichev.me
patch subject: [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev_init
config: i386-buildonly-randconfig-002-20250330 (https://download.01.org/0day-ci/archive/20250330/202503300541.24wTsWWQ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250330/202503300541.24wTsWWQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503300541.24wTsWWQ-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> net/core/dev.c:1774:1: warning: data definition has no type or storage class
    1774 | EXPORT_IPV6_MOD(netif_disable_lro);
         | ^~~~~~~~~~~~~~~
>> net/core/dev.c:1774:1: error: type defaults to 'int' in declaration of 'EXPORT_IPV6_MOD' [-Werror=implicit-int]
>> net/core/dev.c:1774:1: warning: parameter names (without types) in function declaration
   cc1: some warnings being treated as errors


vim +1774 net/core/dev.c

  1756	
  1757	void netif_disable_lro(struct net_device *dev)
  1758	{
  1759		struct net_device *lower_dev;
  1760		struct list_head *iter;
  1761	
  1762		dev->wanted_features &= ~NETIF_F_LRO;
  1763		netdev_update_features(dev);
  1764	
  1765		if (unlikely(dev->features & NETIF_F_LRO))
  1766			netdev_WARN(dev, "failed to disable LRO!\n");
  1767	
  1768		netdev_for_each_lower_dev(dev, lower_dev, iter) {
  1769			netdev_lock_ops(lower_dev);
  1770			netif_disable_lro(lower_dev);
  1771			netdev_unlock_ops(lower_dev);
  1772		}
  1773	}
> 1774	EXPORT_IPV6_MOD(netif_disable_lro);
  1775	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki