[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <564768c3-56f0-4236-86e6-00cacb7b6e7d@kernel.org>
Date: Sun, 30 Mar 2025 11:47:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: net: Add MTIP L2 switch description
On 29/03/2025 23:10, Lukasz Majewski wrote:
>>> +
>>
>> If this is ethernet switch, why it does not reference ethernet-switch
>> schema? or dsa.yaml or dsa/ethernet-ports? I am not sure which one
>> should go here, but surprising to see none.
>
> It uses:
> $ref:·ethernet-controller.yaml#
>
> for "ports".
>
> Other crucial node is "mdio", which references $ref: mdio.yaml#
These are children, I am speaking about this device node.
>
>>
>>> +properties:
>>> + compatible:
>>> + const: nxp,imx287-mtip--switch
>>
>> Just one -.
>>
>
> Ok.
>
>>> +
>>> + reg:
>>> + maxItems: 1
>>> + description:
>>> + The physical base address and size of the MTIP L2 SW module
>>> IO range
>>
>> Wasn't here, drop.
>>
>
> The 'reg' property (reg = <0x800f0000 0x20000>;) is defined in
> imx28.dtsi, where the SoC generic properties (as suggested by Andrew -
> like clocks, interrupts, clock-names) are moved.
Drop description, not the reg. Reg was in the previous version. You
added random changes here, not coming from the previous review.
Best regards,
Krzysztof
Powered by blists - more mailing lists