netdev - Re: [PATCH v2 1/4] dt-bindings: net: Add MTIP L2 switch description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4c8de9b-e52c-480b-a3bf-e82979602477@kernel.org>
Date: Mon, 31 Mar 2025 08:30:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: net: Add MTIP L2 switch description

On 30/03/2025 23:04, Lukasz Majewski wrote:
> Hi Krzysztof,
> 
>> On 29/03/2025 23:10, Lukasz Majewski wrote:
>>>>> +    
>>>>
>>>> If this is ethernet switch, why it does not reference
>>>> ethernet-switch schema? or dsa.yaml or dsa/ethernet-ports? I am
>>>> not sure which one should go here, but surprising to see none.  
>>>
>>> It uses:
>>> $ref:·ethernet-controller.yaml#
>>>
>>> for "ports".
>>>
>>> Other crucial node is "mdio", which references $ref: mdio.yaml#  
>>
>> These are children, I am speaking about this device node.
> 
> It looks like there is no such reference.
> 
> I've checked the aforementioned ti,cpsw-switch.yaml,
> microchip,lan966x-switch.yaml and renesas,r8a779f0-ether-switch.yaml.
> 
> Those only have $ref: for ethernet-port children node.
> 
> The "outer" one doesn't have it.
> 
> 
> Or am I missing something?

There is ethernet-switch.yaml for non-DSA switches and there is DSA
(using ethernet switch, btw). I don't know why these devices do not use
it, I guess no one converted them after we split ethernet-switch out of DSA.

Best regards,
Krzysztof