netdev - Re: [PATCH net v4 01/11] net: switch to netif_disable_lro in inetdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-sD1kYBPZlmpPcr@mini-arch>
Date: Mon, 31 Mar 2025 14:06:30 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net v4 01/11] net: switch to netif_disable_lro in
 inetdev_init

On 03/31, Jakub Kicinski wrote:
> On Mon, 31 Mar 2025 08:05:53 -0700 Stanislav Fomichev wrote:
> > +EXPORT_IPV6_MOD(netif_disable_lro);
> 
> > +++ b/net/ipv4/devinet.c
> 
> >  	if (IPV4_DEVCONF(in_dev->cnf, FORWARDING))
> > -		dev_disable_lro(dev);
> > +		netif_disable_lro(dev);
> >  	/* Reference in_dev->dev */
> >  	netdev_hold(dev, &in_dev->dev_tracker, GFP_KERNEL);
> >  	/* Account for reference dev->ip_ptr (below) */
> 
> I still don't see a way for devinet.c to be built into a module.
> The export and moving the defines needs to go to patch 3.

Ah, I missed that, you're right, will do!